Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testament: timeout doesn't finish process early #24278

Open
metagn opened this issue Oct 10, 2024 · 0 comments
Open

testament: timeout doesn't finish process early #24278

metagn opened this issue Oct 10, 2024 · 0 comments

Comments

@metagn
Copy link
Collaborator

metagn commented Oct 10, 2024

Testament has a timeout property in test specs, but it's only checked after the process is done. It doesn't terminate the test process early if it passes the timeout duration.

The process is created in callNimCompiler but I could not get it to work with waitForExit. Test code that just does sleep(100_000) is not treated as timed out on Windows either by waitForSingleObject or getExitCodeProcess, which gives an exit code of 0 after 1.2 seconds. It would be better than the current situation if it at least worked on other OSes but I don't know if it would.

I was hoping to add a default 5 minute timeout for every test, in #24252 I accidentally wrote an infinite loop in the compiler and it didn't show which test failed because it ran indefinitely and the entire CI was cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant