Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contrast ratio issues for chat page #51

Closed
jdwilkin4 opened this issue Jan 24, 2024 · 1 comment · Fixed by #56
Closed

Fix contrast ratio issues for chat page #51

jdwilkin4 opened this issue Jan 24, 2024 · 1 comment · Fixed by #56
Assignees
Labels
a11y Accessibility bug Something isn't working

Comments

@jdwilkin4
Copy link
Contributor

jdwilkin4 commented Jan 24, 2024

Describe the bug

I ran lighthouse on the chat room page, and we got dinged for contrast ratio issues
The issues were pointing to the leave room and send message buttons.
Screenshot 2024-01-23 at 9 47 21 PM

It looks like changing the Leave room button color to bg-red-600 and changing the Send message button color to bg-blue-600 should resolve the issue

Screenshot 2024-01-23 at 9 48 28 PM

Steps to reproduce

  1. Go to https://astro-partykit-react-starter.netlify.app/
  2. join room
  3. Open chrome dev tools
  4. Run lighthouse on chat page
  5. See lighthouse report for contrast ratio

Expected behavior

Lighthouse should produce 100 score for accessibility

Desktop details

Smartphone details

Additional context

@jdwilkin4 jdwilkin4 added bug Something isn't working needs triage issue waiting to be triaged a11y Accessibility labels Jan 24, 2024
@jdwilkin4 jdwilkin4 changed the title Fix contrast ratio issues Fix contrast ratio issues for chat page Jan 24, 2024
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take".

For full info on how to contribute, please check out our contributors guide.

@jdwilkin4 jdwilkin4 self-assigned this Jan 28, 2024
@jdwilkin4 jdwilkin4 removed the needs triage issue waiting to be triaged label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant