-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: The default username if none is specified is incorrect. #3
Comments
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". For full info on how to contribute, please check out our contributors guide. |
See these lines of code, astro-partykit-starter/src/pages/chat/index.astro Lines 5 to 8 in 53ea0fb
And this is the change required. - const username =
+ const username = Astro.url.searchParams.get("username") ?? "anonymous";
- Astro.url.searchParams.get("username") ??
- "astro-partykit-room" ??
- "Anonymous"; |
Hey @nickytonline can I jump on this? |
Wanted to just ask about this too now too😅 |
Just read the info in this comment to self assign it @heysolomon. |
.take |
Describe the bug
This code was a copy and paste error when I set up the project.
Expected behavior
It should be
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: