Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-core template version badges to README #3396

Merged
merged 14 commits into from
Feb 13, 2025
Merged

Add nf-core template version badges to README #3396

merged 14 commits into from
Feb 13, 2025

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 14, 2025

Should add automation to bump the template version on sync, but that's for cleverer people than myself.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 requested a review from mirpedrol January 14, 2025 09:45
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge version will update when updating the template now. I have also fixed the bump-version command and lining.
I will let @mashehu or someone else review my code since I added quite a bit 😄

@mirpedrol mirpedrol requested a review from mashehu February 12, 2025 16:00
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.49%. Comparing base (38813b0) to head (08e0d7e).
Report is 43 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/lint/readme.py 85.71% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing about what to link, rest looks good

nf_core/pipeline-template/README.md Outdated Show resolved Hide resolved
nf_core/pipelines/create/template_features.yml Outdated Show resolved Hide resolved
@mirpedrol mirpedrol merged commit abb3acf into dev Feb 13, 2025
91 checks passed
@mirpedrol mirpedrol deleted the version-badges branch February 13, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants