Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core lint disagrees with prettier #2606

Closed
Aratz opened this issue Dec 20, 2023 · 4 comments
Closed

nf-core lint disagrees with prettier #2606

Aratz opened this issue Dec 20, 2023 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@Aratz
Copy link
Contributor

Aratz commented Dec 20, 2023

Description of the bug

When running nf-core lint, it will rewrite modules.json as follows:

"installed_by": [
     "modules"
]

However, this goes against Prettier, who has strong feelings for

"installed_by": ["modules"]

Steps to reproduce:

  1. go to a pipeline repository (e.g. nf-core/demultiplex)
  2. Run nf-core lint, this will change modules.json
  3. Run npx prettier --check .. This will raise a warning about modules.json

Command used and terminal output

No response

System information

  • nf-core/tools version 2.11
  • prettier v2.8.7
@Aratz Aratz added the bug Something isn't working label Dec 20, 2023
@maxulysse
Copy link
Member

I think it's a known issue already feature

@mashehu
Copy link
Contributor

mashehu commented Dec 20, 2023

We had it fixed and I reintroduced this by accident, while making the code run faster. Sorry

@mirpedrol mirpedrol added this to the 2.11.1 milestone Dec 20, 2023
@Aratz
Copy link
Contributor Author

Aratz commented Dec 20, 2023

No worries 🙂

@mashehu
Copy link
Contributor

mashehu commented Dec 20, 2023

fixed in #2609

@mashehu mashehu closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants