Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs mirtop #482

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Add docs mirtop #482

merged 4 commits into from
Nov 12, 2024

Conversation

atrigila
Copy link
Contributor

@atrigila atrigila commented Nov 12, 2024

Improve docs regarding input files from MirgeneDB

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@atrigila atrigila added this to the 2.4.1 milestone Nov 12, 2024
@atrigila atrigila self-assigned this Nov 12, 2024
@nschcolnicov
Copy link
Contributor

Hi @atrigila, I already updated the mirgenedb hairpin file: https://github.com/nf-core/test-datasets/blob/smrnaseq/MirGeneDB/mirgenedb_hsa_hairpin.fa. This was what was causing the issue #477. Apparently we had the wrong links from the start d5500c3.
Or are you referring to something else?

Copy link
Contributor

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion to make it even more clear, regardless if you add it or not, looks good to me!

docs/usage.md Outdated Show resolved Hide resolved
Co-authored-by: Nicolás Schcolnicov <[email protected]>
@atrigila atrigila merged commit c06b188 into nf-core:dev Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants