Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust bits from PR review #278

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Adjust bits from PR review #278

merged 2 commits into from
Sep 4, 2023

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Sep 4, 2023

This simply addresses the points raised in the release PR :)

christopher-mohr
christopher-mohr approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0752c18

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-04 10:08:17

jfy133
jfy133 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess looks OK, however still missing the changelog update about the change to the .gz files for the mature and hairpin parameters. I would argue that's important if people want to download manually themselves?

@apeltzer
Copy link
Member Author

apeltzer commented Sep 4, 2023

I guess looks OK, however still missing the changelog update about the change to the .gz files for the mature and hairpin parameters. I would argue that's important if people want to download manually themselves?

Ah now I know what you mean :) I will do that yes 👍🏻

@apeltzer apeltzer merged commit ddaa74a into dev Sep 4, 2023
@apeltzer apeltzer deleted the fix-pr-points branch September 4, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@christopher-mohr christopher-mohr christopher-mohr approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeltzer @christopher-mohr @jfy133