Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container syntax in INDEX_CONTAMINANTS #250

Closed
wants to merge 3 commits into from
Closed

Fix container syntax in INDEX_CONTAMINANTS #250

wants to merge 3 commits into from

Conversation

adamrtalbot
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented May 17, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0843569

+| ✅ 159 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in README.md: update the following command to include all required parameters for a minimal example

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-31 12:21:37

apeltzer
apeltzer approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did that actually break anything?

@adamrtalbot
Copy link
Contributor Author

We were trying to write a script to get all the docker containers, this one didn't match the pattern so wasn't caught. I've updated the script but thought it would be good to fix the code itself.

It might break nf-core download?

@drpatelh
Copy link
Member

I think it might have something to do with the NF version. We are looking at it internally.

@apeltzer apeltzer added this to the 2.2.1 milestone Aug 30, 2023
@apeltzer
Copy link
Member

is this still relevant?

@apeltzer apeltzer closed this Aug 30, 2023
@apeltzer apeltzer deleted the fix_container_syntax_INDEX_CONTAMINANTS branch September 1, 2023 12:32
nschcolnicov pushed a commit that referenced this pull request Oct 10, 2024
@apeltzer
Merge pull request #250 from nf-core/bump-versions
24edd51 
Bump versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

@apeltzer apeltzer apeltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@adamrtalbot @drpatelh @apeltzer