Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate trunk and Marron and Wand simulations error checks #230

Open
sampan501 opened this issue Feb 23, 2024 · 0 comments
Open

Consolidate trunk and Marron and Wand simulations error checks #230

sampan501 opened this issue Feb 23, 2024 · 0 comments

Comments

@sampan501
Copy link
Member

sampan501 commented Feb 23, 2024

Looks good! For simplicity, there is a lot of error checks that are common for all 3 functions. Maybe we can wrap those up into a private method?

Good idea. Rn tho there's only a few. We could migrate the covariance matrix stuff to a _default_covariance(...) which handles the check and setting of covariance possibly. But maybe we can leave for later depending on any future added complexity. Otw over-engineering maybe :p

Originally posted by @adam2392 in #227 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant