You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks good! For simplicity, there is a lot of error checks that are common for all 3 functions. Maybe we can wrap those up into a private method?
Good idea. Rn tho there's only a few. We could migrate the covariance matrix stuff to a _default_covariance(...) which handles the check and setting of covariance possibly. But maybe we can leave for later depending on any future added complexity. Otw over-engineering maybe :p
Good idea. Rn tho there's only a few. We could migrate the covariance matrix stuff to a
_default_covariance(...)
which handles the check and setting of covariance possibly. But maybe we can leave for later depending on any future added complexity. Otw over-engineering maybe :pOriginally posted by @adam2392 in #227 (comment)
The text was updated successfully, but these errors were encountered: