Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if converter's scale_firing_rates would skew the nonlinearities #207

Open
arvoelke opened this issue Feb 24, 2021 · 0 comments
Open

Comments

@arvoelke
Copy link
Contributor

Related to #206.

Currently the nengo_dl converter's scale_firing_rates will gladly change the effective response that you get from any nonlinearity except for the linear/ReLU activations. There is this warning:

warnings.warn(
f"Firing rate scaling being applied to activation type "
f"that does not support amplitude "
f"({type(activation).__name__}); "
f"this will change the output"
)

But this is only emitted for neuron types that don't support amplitude. I'd expect a similar (or generalized) warning to be emitted if the neuron's activation function is going to be skewed by the rescaling, as this also changes the output of the neuron. Otherwise the model may perform worse, as the trained weights would be w.r.t. the wrong nonlinearities, which could be confusing for someone who misses this subtlty about scale_firing_rates in the converter's docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant