Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Secrets Manager external secrets bug w/Google #12947

Open
bcharleson opened this issue Jan 30, 2025 · 8 comments · May be fixed by #13110
Open

AWS Secrets Manager external secrets bug w/Google #12947

bcharleson opened this issue Jan 30, 2025 · 8 comments · May be fixed by #13110
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@bcharleson
Copy link

Describe the problem/error/question

Hello n8n team!

We are facing a potential bug issue that we are seeing using the AWS secrets manager. Google seems to be the only one that is not passing through the token. All other external secrets are passing through appropriately.

We have the enterprise self-hosted n8n with v 1.77.0 and the bug still persists.

Let me know if I need to route this any other direction but figured the community would be a good start.

Thanks!

Brandon

Image

Image

What is the error message (if any)?

API token is not passing through

(Select the nodes on your canvas and use the keyboard shortcuts CMD+C/CTRL+C and CMD+V/CTRL+V to copy and paste the workflow.)
⚠️ WARNING ⚠️ If you have sensitive data in your workflow (like API keys), please remove it before sharing.

Debug info

core

  • n8nVersion: 1.77.0
  • platform: docker (self-hosted)
  • nodeJsVersion: 20.18.2
  • database: sqlite
  • executionMode: regular
  • concurrency: -1
  • license: enterprise (production)

storage

  • success: all
  • error: all
  • progress: false
  • manual: true
  • binaryMode: memory

pruning

  • enabled: true
  • maxAge: 336 hours
  • maxCount: 10000 executions

client

  • userAgent: mozilla/5.0 (macintosh; intel mac os x 10_15_7) applewebkit/537.36 (khtml, like gecko) chrome/133.0.0.0 safari/537.36
  • isTouchDevice: false

Generated at: 2025-01-30T02:52:15.216Z}

@Joffcom
Copy link
Member

Joffcom commented Jan 30, 2025

Hey @bcharleson,

We have created an internal ticket to look into this which we will be tracking as "GHC-670"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Jan 30, 2025
@bcharleson
Copy link
Author

Awesome, thank you!

@bcharleson
Copy link
Author

@Joffcom -- if you don't mind, can we please loop in @iandreileo into this ticket? We are working together on this. Thanks!

@Joffcom
Copy link
Member

Joffcom commented Jan 30, 2025

Are you using oauth with other tools as well with a similar pattern to the secret?

@iandreileo
Copy link

Hi @Joffcom ,

No, we don't.

It seems like the problem is somewhere on the OAuth nodes from Google or something because we use the AWS secrets managers with other nodes in n8n, and it works perfectly.

Also, it seems like the secrets are correctly retrieved by n8n, but they are not added in the OAuth request.

Thanks!

@Joffcom
Copy link
Member

Joffcom commented Jan 31, 2025

Hey @iandreileo,

Perfect thanks, I will pass this over to the team that looks after secrets so they can debug it a but more. I suspect it won't just be Google credentials it will be all OAuth ones. For now it might be worth not using the secret so you can at least connect, Someone from the team will be in touch once they pick this up.

@iandreileo
Copy link

Hello,

Is there any news here?

Thanks so much!

@Joffcom
Copy link
Member

Joffcom commented Feb 5, 2025

Hey @iandreileo

It is being looked into, someone from the team will be in touch if they have any other questions.

@MarcL MarcL linked a pull request Feb 6, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants