-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addon+version uniqueness won't be compatible with MV3 (new version format) #185
Comments
This bug is semi-related to this issue, although the XPI is an MV2 extension: https://bugzilla.mozilla.org/show_bug.cgi?id=1795750 |
We'll need to update this code when we decide what the version should look like. |
We could do |
It seems there's a warning about this in Firefox now mozilla-extensions/aboutsync#110 |
I'm thinking of going with |
We probably need to document the fact that extensions will only be able to use |
One more thing: |
Can you please reconsider this new format? |
Sorry, I don't think that's an option. |
FYI, I landed a patch to update the version string in langpacks: https://bugzilla.mozilla.org/show_bug.cgi?id=1796531 |
@gabrielBusta hey, any progress on this? (I am just curious, this is the last identified bug I have for the rollout of this new version format) Thanks! |
Yay, thank you! |
The addon+version uniqueness implemented in #135 will not be compatible with MV3 because we encourage a new simpler version string format in the manifest. In practice, it means:
We'll need to update the
build
step to account for that when MV3 extensions will start to be signed. At the moment, MV3 extensions won't be accepted by the linter, though (the linter task is blocking for privileged add-ons since #169).The text was updated successfully, but these errors were encountered: