Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Bitrate option needs exponential scaling. #469

Open
airdjing opened this issue Jun 1, 2018 · 5 comments
Open

[Suggestion] Bitrate option needs exponential scaling. #469

airdjing opened this issue Jun 1, 2018 · 5 comments

Comments

@airdjing
Copy link

airdjing commented Jun 1, 2018

First, Sorry for my bad english.

This is not an issue. It's a suggestion.
The current bit rate option is modified only in increments of 500kbps.
I think the current bit rate option needs exponential scaling.
500kbps and 1000kbps differ greatly in quality.
However, there is little difference between 10000 and 10500 kilobits.

The higher the bandwidth, the less it means to adjust the unit of 500kbps.
These units take up only the space in the slide bar, making it very difficult to fine-tune them at low bandwidth.
I think that needs to be controlled properly.

The bit rate units I propose are as follows.

500kbps
1000kbps
1500kbps
2000kbps
3000kbps
4000 kbps
5000kbps
6000 kbps
8000kbps
10000kbps
12000kbps
15000kbps
18000kbps
20000kbps
30000kbps
40000kbps
50000kbps
60000kbps
80000kbps
100000 kbps

@jorys-paulin
Copy link
Collaborator

jorys-paulin commented Jun 2, 2018

@airdjing The best would be to have an input next to the slider to enter custom values. For the exponential increase, I think the material slider is only linear (but we can change that).

@Zibbibbo
Copy link

Zibbibbo commented Jun 8, 2018

Honestly I prefer to have the 500k incremental linear scaling, i use exactly 17.5m on the slider, i've done many many tests to reach the perfect setting based on my host upload line, at 18 the streaming start to lag, under 17 it shown many compression artifacts, so for me is perfect 17/17.5 with no artifact and no lag.
I don't get the real utility of change with an exponential scaling, it will lose accuracy for the fine-tuning

@airdjing
Copy link
Author

@jorys-paulin It's too difficult to fine-tune. Can you make a text box? I think need an Android version too. I think bitrate text box is a good alternative.

@jorys-paulin
Copy link
Collaborator

@airdjing I may do it, I just tried making a prototype, but the code is too messy it's impossible to add anything...

@jorys-paulin
Copy link
Collaborator

@airdjing I just did it. Required to rework the code, but made it! You can check it out, over on #476. When it comes to an exponential increase, I don't think it's possible, plus I think it will confuse the users more than anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants