Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump whatwg-url from 13.0.0 to 14.0.0 #39

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 7, 2024

Bumps whatwg-url from 13.0.0 to 14.0.0.

Release notes

Sourced from whatwg-url's releases.

14.0.0

Breaking change: removed Node.js v16 support.

Commits
  • 6c6fb17 14.0.0
  • 3f5e1a0 Use official GitHub Actions for live viewer deployment
  • bd27527 Update web platform tests
  • d8fe415 Move from Jest to Node.js test runner and c8
  • f9cbc85 Update dependencies and dev dependencies
  • b292124 Raise minimum Node.js version to v18
  • ce40284 Reflect the change from master to main
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [whatwg-url](https://github.com/jsdom/whatwg-url) from 13.0.0 to 14.0.0.
- [Release notes](https://github.com/jsdom/whatwg-url/releases)
- [Commits](jsdom/whatwg-url@v13.0.0...v14.0.0)

---
updated-dependencies:
- dependency-name: whatwg-url
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 7, 2024
@nbbeeken nbbeeken added the Blocked Blocked on other work label Nov 7, 2024
@nbbeeken
Copy link
Collaborator

nbbeeken commented Nov 7, 2024

Breaking change: removed Node.js v16 support.

Blocker for us currently

@andriijas
Copy link

andriijas commented Nov 27, 2024

Breaking change: removed Node.js v16 support.

Blocker for us currently

Isnt it time to drop node 16 support? Its not maintained anymore https://nodejs.org/en/about/previous-releases
and others have started to drop support for it

Bumping whatwg-url to 14 should fix
"[DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead."

@Thrashattack
Copy link

Thrashattack commented Dec 3, 2024

Breaking change: removed Node.js v16 support.

Blocker for us currently

What is the current usage percentage of this library with NodeJS 16 to justify it being a blocker? At least for a next release.

@nbbeeken
Copy link
Collaborator

nbbeeken commented Dec 3, 2024

Hey @andriijas @Thrashattack, thanks for reaching out! changing compatibility with node versions is a breaking change so we plan to drop node 16 support when we're ready to start the next major of the driver which is already on our horizon. However, [email protected] is going to need to remain compatible with node 16 so we need to remain on [email protected] in [email protected].

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 1, 2025

Superseded by #53.

@dependabot dependabot bot closed this Jan 1, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/whatwg-url-14.0.0 branch January 1, 2025 01:50
@nbbeeken
Copy link
Collaborator

Fixed in: #54

Turns out npm will select the correct version based on the engine field if we allow either 13.x or 14.x to be a dependency of this package, so we're unblocked from fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Blocked on other work dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants