Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VersionX resource delta previews #29

Open
muzzwood opened this issue Nov 15, 2024 · 3 comments
Open

Add support for VersionX resource delta previews #29

muzzwood opened this issue Nov 15, 2024 · 3 comments

Comments

@muzzwood
Copy link
Contributor

I'd love to see a MagicPreview button on each VersionX resource delta allowing that point in time to be loaded visually.

@jenswittmann
Copy link
Contributor

@muzzwood and @Mark-H what about crowdfunding this via donation? Can you calculate how much money is needed?

@muzzwood
Copy link
Contributor Author

muzzwood commented Dec 17, 2024

This was an off-the-cuff comment I added when thinking about it. I haven't looked too in-depth at how involved it might be yet... but will do when I get a chance.
It might be "just" a matter of running a restore without saving in VersionX, and then giving that data to MagicPreview to use instead of the current resource.. but there could be a whole lot of problems with doing so that I'm unaware of yet.
One problem will be that assets previously used in a page may not exist at the same location anymore. But there's not much we can do about that.

@jenswittmann if you have any ideas on how to display preview buttons in the VersionX UI, let me know 😃

@jenswittmann
Copy link
Contributor

jenswittmann commented Dec 20, 2024

It might be "just" a matter of running a restore without saving in VersionX, and then giving that data to MagicPreview to use instead of the current resource.. but there could be a whole lot of problems with doing so that I'm unaware of yet.

This preview feature may be toggled (true/false) in the system settings. This allows you to turn it off for certain sites.

One problem will be that assets previously used in a page may not exist at the same location anymore. But there's not much we can do about that.

I think WordPress has the same problem. But that is ok, because sometimes you want a piece of text or something like that.

@jenswittmann if you have any ideas on how to display preview buttons in the VersionX UI, let me know 😃

Maybe keep it simple?

image

I want to put this on the roadmap. Maybe @muzzwood can calculate a dummy version and we can collect money for it 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants