Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSet form fields that should be a controlled list/pulldown/radio #1742

Open
sethaj opened this issue Apr 16, 2018 · 0 comments
Open

FileSet form fields that should be a controlled list/pulldown/radio #1742

sethaj opened this issue Apr 16, 2018 · 0 comments

Comments

@sethaj
Copy link
Member

sethaj commented Apr 16, 2018

There are some FileSet form fields that should not be free text but something else. "Allow Download" for instance needs to be lowercase "yes", not "Yes" which is very confusing.

https://github.com/mlibrary/heliotrope/blob/master/app/presenters/hyrax/file_set_presenter.rb#L104

Find all the form elements that should be controlled, make them radio buttons or dropdowns. Maybe reconsider using english "yes"/"no" and opt for true/false or 0/1.

@sethaj sethaj added this to the Summer milestone Apr 16, 2018
@mbakeryo mbakeryo added ready and removed ready labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants