Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "More Actions..." ellipsis button from Open Editors in explorer #240073

Open
nyoung697 opened this issue Feb 8, 2025 · 12 comments · May be fixed by #241268 or #241069
Open

Remove "More Actions..." ellipsis button from Open Editors in explorer #240073

nyoung697 opened this issue Feb 8, 2025 · 12 comments · May be fixed by #241268 or #241069
Assignees
Labels
open-editors Issues related to the OPEN EDITORS view under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@nyoung697
Copy link

Image

Why is this button here all of a sudden? Please remove it...

I keep accidentally closing all my open editors, instead of hitting Save All, because the buttons are shifted over :|

@gjsjohnmurray
Copy link
Contributor

I suggest you right-click on the "Close All Editors" button and choose the option to hide it. This will make it move to the "..." overflow menu which arrived on the open Editors view in 1.97 when the new Configure 'Open Editors' command was added to the view.

@benc-uk
Copy link

benc-uk commented Feb 10, 2025

I've tried this several other combos of hiding stuff here and nothing removes the pointless ellipsis

@gjsjohnmurray
Copy link
Contributor

It's not pointless. As is the convention with other views' action bars it gives access to actions that don't have their own button on the title bar.

@gjsjohnmurray
Copy link
Contributor

@nyoung697 did my suggestion solve your muscle memory issue?

@NikVogri
Copy link

NikVogri commented Feb 11, 2025

This is bothering me also. It would be nice to let us hide the ellipsis.

@lennu
Copy link

lennu commented Feb 17, 2025

Its a big change for anyone who has been using this in their workflow. For example click "Close all editors" and then click right below "Collapse folders in explorer" is a nice way to clean the editor from last thing you were doing and continue to the next.

Now its a bit painful and slow to find that "Close all editors" button since you have to look for it instead of it being always the rightmost item.

@gjsjohnmurray
Copy link
Contributor

@lennu please see my comment at #241025 (comment)

@benibenj benibenj assigned benibenj and unassigned lramos15 Feb 17, 2025
@benibenj benibenj added the open-editors Issues related to the OPEN EDITORS view label Feb 17, 2025
@benibenj benibenj added this to the February 2025 milestone Feb 17, 2025
@benibenj benibenj added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 17, 2025
@benibenj
Copy link
Contributor

Even though I like the idea of the configure action, I'm considering reverting the change. My long term idea would have been to add this to all views which have settings, however, I see that this will lead to having overflow actions on many views where there currently is none. This will break a lot of users muscle memory and clutter the view titles. If we consider such an action to be of value, we could consider other ways of exposing this. Maybe view context menu...?

@gjsjohnmurray
Copy link
Contributor

Per #108271 (comment) it seems likely that Explorer view will someday acquire a "..." button. Rather than reverting the change that introduced it to Open Editors I suggest getting it added to Explorer ASAP (see #108271 (comment)), even if we extension developers have to wait a bit longer for the menu contribution point to get implemented.

Pinging @lramos15

@thany
Copy link

thany commented Feb 18, 2025

See #241025 (comment).

Basically, please don't clutter vscode with ... menus everywhere. They need to make sense, and frankly I agree with OP, they are pointless. They could just as well go into the right-click menu, which astoundingly is yet another more different menu on the same element.

@lramos15
Copy link
Member

Per #108271 (comment) it seems likely that Explorer view will someday acquire a "..." button. Rather than reverting the change that introduced it to Open Editors I suggest getting it added to Explorer ASAP (see #108271 (comment)), even if we extension developers have to wait a bit longer for the menu contribution point to get implemented.

Pinging @lramos15

I think the true solution we need is to be able to promot and demote any action into a ... menu or out of ... menu and have that hide or show it.

That way the extension authors could then contribute and it would automatically start rendering .... Rather than us adding ... everywhere just for there to be contribution points.

@gjsjohnmurray
Copy link
Contributor

I have submitted PR #241268 to allow the button to be hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-editors Issues related to the OPEN EDITORS view under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
8 participants