Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Add shell type check #238371

Closed
Tyriar opened this issue Jan 21, 2025 · 1 comment · Fixed by #238381
Closed

Terminal suggest: Add shell type check #238371

Tyriar opened this issue Jan 21, 2025 · 1 comment · Fixed by #238381
Assignees
@meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-suggest verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 21, 2025

This proposed API was merged and ready to test #230165

cc @anthonykim1
@meganrogge meganrogge added this to the January 2025 milestone Jan 21, 2025
@meganrogge meganrogge added the feature-request Request for new features or functionality label Jan 21, 2025
meganrogge added a commit that referenced this issue Jan 21, 2025
@meganrogge
wip #238371
0249116
@meganrogge meganrogge mentioned this issue Jan 21, 2025
Merged
Tyriar added a commit that referenced this issue Jan 23, 2025
@Tyriar
Initialize shellType state after reconnect
ff51c4b 
Part of #238371
@Tyriar Tyriar mentioned this issue Jan 23, 2025
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 23, 2025
@meganrogge meganrogge added the verification-needed Verification of issue is requested label Jan 27, 2025
@meganrogge
Copy link
Contributor

Verify that with terminal suggest enabled on macOS, you see completions for zsh, bash, and pwsh.

@roblourens roblourens added the verified Verification succeeded label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-suggest verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

use terminalShellType for terminal suggest microsoft/vscode
3 participants
@roblourens @Tyriar @meganrogge