Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update download-artifact and upload-artifact actions to v4 #24398

Open
petetronic opened this issue Nov 6, 2024 · 1 comment
Open

Chore: Update download-artifact and upload-artifact actions to v4 #24398

petetronic opened this issue Nov 6, 2024 · 1 comment
Assignees
@eleanorjboyd
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@petetronic
Copy link

Chore: GitHub announced that v3 of actions/upload-artifact and actions/download-artifact will be closing down and would start brownouts on November 14th. The change required is to simply move to v4 of these actions.

See:
https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

.github/actions/build-vsix/action.yml

-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4

.github/actions/smoke-tests/action.yml

-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
@petetronic petetronic added the feature-request Request for new features or functionality label Nov 6, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 6, 2024
@eleanorjboyd eleanorjboyd self-assigned this Nov 6, 2024
@eleanorjboyd
Copy link
Member

Yes we are planning on doing this. I saw your PR regarding this problem: #24395. Any reason you closed it? We could iterate on that and merge this in to fix that problem. Thanks

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. info-needed Issue requires more information from poster and removed feature-request Request for new features or functionality labels Nov 6, 2024
@karthiknadig karthiknadig added needs PR Ready to be worked on and removed info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleanorjboyd eleanorjboyd

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petetronic @karthiknadig @eleanorjboyd