Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shell type API from core to detect shell type #116

Closed
anthonykim1 opened this issue Jan 16, 2025 · 3 comments
Closed

Use shell type API from core to detect shell type #116

anthonykim1 opened this issue Jan 16, 2025 · 3 comments
Assignees
Labels

Comments

@anthonykim1
Copy link
Contributor

Instead of trying to detect and figure out shell type from extension side: https://github.com/microsoft/vscode-python-environments/blob/main/src/features/common/shellDetector.ts

We should eventually switch over to using terminal shell type from core. Related issue: microsoft/vscode#230165

@anthonykim1 anthonykim1 self-assigned this Jan 16, 2025
@anthonykim1 anthonykim1 changed the title Use Shell Type API from core to detect shell type Use shell type API from core to detect shell type Jan 16, 2025
@flying-sheep
Copy link
Contributor

flying-sheep commented Jan 24, 2025

in #137, I’m adding some type safety to shell type handling.

if we merge that PR before we switch to core APIs, we need to take care to not break its type safe way to make sure all shells are handled in all pieces of the code that handle shells.

@anthonykim1
Copy link
Contributor Author

anthonykim1 commented Jan 27, 2025

Hi @flying-sheep I appreciate you letting me know.
Shell type API (proposed) did get merged just last week, so it may be good idea if we start using it, and hopefully make the shell detection more reliable for activation/deactivation. Though I don't think the list of shell types identically match though.

The goal is I want to lessen the burden so we do less prediction of shell types and environments on extension side of things.
There is also shell environment APIs that are coming up too!

@karthiknadig
Copy link
Member

Done via #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants