Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag entries from the new tab menu to create panes #9229

Open
CyprusSocialite opened this issue Feb 20, 2021 · 3 comments
Open

Drag entries from the new tab menu to create panes #9229

CyprusSocialite opened this issue Feb 20, 2021 · 3 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@CyprusSocialite
Copy link

CyprusSocialite commented Feb 20, 2021

As I am aware, creating a new pane is currently possible via the [Alt]+[Shift]+[-/=] shortcuts, which allow the user to decide how the existing pane will be split but always use the default profile for the new pane, or by [Alt]+[LMB] clicking on the dropdown menu, which allows a specific profile to be selected but splits the pane automatically.

I think the ability to select both the profile and the orientation of new panes would be desirable. I propose a number of possible approaches:

  • Creating new horizontal/vertical panes from the dropdown via [Alt]+[-/=]+[LMB] or simply [LMB/RMB] respectively.

  • A global setting along the lines of 'useCurrentProfile' that would make the [Alt]+[Shift]+[-/=] shortcuts use the profile of the current pane rather than the default one. This doesn't quite allow the selection of any profile, but still covers an important use case.

  • Dragging profile names from the dropdown menu to the desired position of the new pane with some sort of dynamic preview of how the panes will be split. The most user-friendly and visually pleasing option, but perhaps harder to implement.

@CyprusSocialite CyprusSocialite added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 20, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 20, 2021
@DHowett
Copy link
Member

DHowett commented Feb 20, 2021

Dragging profile names from the [menu]

That's really clever. I don't think we can pull it off, but it's very clever. I like it.

Right now, the predominant ways to achieve what you're looking for are via the command palette (ctrl+shift+p, "Split pane ..." > Profile > Direction) or custom bindings.

It's possible to override the default bindings for alt+shift+- and alt+shift+= to use the "duplicate" split mode. More info here on the split pane docs.

Does that help?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 20, 2021
@CyprusSocialite
Copy link
Author

Right now, the predominant ways to achieve what you're looking for are via the command palette (ctrl+shift+p, "Split pane ..." > Profile > Direction) or custom bindings.

Admittedly, I wasn't aware of the command palette, so that's good to know for general purposes

It's possible to override the default bindings for alt+shift+- and alt+shift+= to use the "duplicate" split mode. More info here on the split pane docs.

I'm mostly interested in duplicating panes anyway, so this is very helpful. Thank you!

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 20, 2021
@zadjii-msft
Copy link
Member

It sounds like the command palette and the "duplicate pane" options generally fit your other needs. I'm going to leave this open to track the last part of your request -

Dragging profile names from the dropdown menu to the desired position of the new pane with some sort of dynamic preview of how the panes will be split. The most user-friendly and visually pleasing option, but perhaps harder to implement.

Because that's a unique ask that I don't think we've heard before. #4587 is vaguely similar, but with a tab itself, not the dropdown entry.

@zadjii-msft zadjii-msft changed the title Choose profile and orientation of new panes Drag entries from the new tab menu to create panes Feb 23, 2021
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Feb 23, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 23, 2021
@zadjii-msft zadjii-msft removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 23, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Feb 23, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants