Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In newTabMenu allow assignment/override of the icon property for the action items #18103

Closed
AbraxasDMG opened this issue Oct 23, 2024 · 3 comments · Fixed by #18116
Closed

In newTabMenu allow assignment/override of the icon property for the action items #18103

AbraxasDMG opened this issue Oct 23, 2024 · 3 comments · Fixed by #18116
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@AbraxasDMG
Copy link

AbraxasDMG commented Oct 23, 2024

Description of the new feature

Hi.

One small cosmetic suggestion.

Currently, I can define actions->command which I can then select as the action in newTabMenu.
If I would like to have an icon (or glyph) for that item displayed in the newTabMenu, icon needs to be defined at the level of actions->command. That will result in icon being visible in the command palette as well, which I'd like to avoid (I don't like it visually to have only one or a few items with the icon in a long list of commands).

Would it be possible to have a possibility to define "icon" for newTabMenu action items ("type": "action"). That would allow assignment of desired icons/glyphs to desired commands only in newTabMenu and not in command palette.

Other option would be to have a property on the actions->command item level that would allow for the icon not to be displayed in the command palette (e.g. iconVisibility to have one of the following values: "newtabmenu", "commandpalette", "both", "none").

One more thing that could work is to allow the whole custom command to be excluded from the command palette.

Thank you in advance!

Proposed technical implementation details

No response

@AbraxasDMG AbraxasDMG added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 23, 2024
@zadjii-msft
Copy link
Member

It should totally let you do that! This must have just been overlooked in the initial implementation.

Something like:

        {
            "type": "action",
            "id": "User.scrollToMark.D3F0B923",
            "icon": "d:\\dev\\public\\terminal\\res\\terminal.ico"
        }

should totally work. Thanks for filing!

(We should probably allow that for profile entries too)

@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Help Wanted We encourage anyone to jump in on these. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 23, 2024
@zadjii-msft zadjii-msft added this to the Backlog milestone Oct 23, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 27, 2024
@GeekJosh
Copy link
Contributor

Hi, I think this would be a really nice feature to add so I have opened a draft PR to implement your suggestion: #18116

It's in draft right now with just the action entry updated to support custom icons. I will add support for Profile entries too before finalising the PR

@GeekJosh
Copy link
Contributor

GeekJosh commented Oct 27, 2024

I have added the ability to override profile icons now too so I have opened the PR for review.

I have also and opened a PR to update the relevant docs here: MicrosoftDocs/terminal#808

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants