Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfocusedAppearance in "defaults" overwrites unfocused background in all profiles #14337

Closed
thgross opened this issue Nov 4, 2022 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@thgross
Copy link

thgross commented Nov 4, 2022

Windows Terminal version

1.15.2874.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

use this in the "defaults" profile:

"unfocusedAppearance": {
    "foreground": "#a0a0a0"
}

and something like this in a profile:

{
    "background": "#101050",
    "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
    "hidden": false,
    "name": "PowerShell",
    "source": "Windows.Terminal.PowershellCore",
    "tabColor": "#202080"
}

Expected Behavior

when the pane is out of focus, only the foreground-color should change to #a0a0a0.

Actual Behavior

when the pane is out of focus, not only the foreground-color changes, but also the background-color goes black.

@thgross thgross added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 4, 2022
@thgross thgross changed the title unfocusedAppearance in "defaults" overwrites background in all profiles unfocusedAppearance in "defaults" overwrites unfocused background in all profiles Nov 4, 2022
@carlos-zamora
Copy link
Member

This is actually confusing, but by design. The unfocused appearance in defaults inherits from the regular appearance in defaults. So when background isn't found in defaults.unfocusedAppearance, we go ahead and use the one in defaults instead. Assuming you have a background defined in defaults, this is probably what's going on.

If you're curious, here's the spec: https://github.com/microsoft/terminal/blob/main/doc/specs/%233062%20-%20Appearance%20configuration%20object%20for%20profiles.md

That said, we probably should mention this weird behavior over in the docs site.

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2022
@carlos-zamora carlos-zamora added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Nov 7, 2022
@zadjii-msft
Copy link
Member

Docs issue is MicrosoftDocs/terminal#610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Development

No branches or pull requests

3 participants