Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate errors while building agent image #970

Closed
anubhabMajumdar opened this issue Nov 7, 2024 · 1 comment · Fixed by #977
Closed

Investigate errors while building agent image #970

anubhabMajumdar opened this issue Nov 7, 2024 · 1 comment · Fixed by #977
Assignees
@timraymond
Labels
area/infra Test, Release, or CI Infrastructure priority/0 P0 type/bug Something isn't working

Comments

@anubhabMajumdar
Copy link
Contributor

Describe the bug

The go mod tidy step is throwing errors. Investigate why and remove the errors.

To Reproduce

Pipeline - https://github.com/microsoft/retina/actions/runs/11725715065/job/32662674487#step:8:568

Expected behavior

No errors.

Screenshots

Image

Platform (please complete the following information):

  • OS: Linux
  • Kubernetes Version: [e.g. 1.22]
  • Host: [e.g. AKS, KIND, self-host, etc]
  • Retina Version:

Additional context
Add any other context about the problem here.
@anubhabMajumdar anubhabMajumdar added area/infra Test, Release, or CI Infrastructure priority/0 P0 type/bug Something isn't working labels Nov 7, 2024
@timraymond timraymond self-assigned this Nov 7, 2024
@timraymond timraymond mentioned this issue Nov 8, 2024
Merged
@timraymond
Copy link
Member

This was not go mod tidy -- that's only a suggestion from the output of the Go toolchain. The problem here is go generate is running mockgen, which is only used for tests. The go generate lines invoking mockgen should only be invoked locally and their byproducts should be checked in. There's no reason to run these in pipelines--it's just a waste of compute.

github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2024
@timraymond
fix: Remove mockgen from go generate step (#977)
d8cda5b 
We don't need to generate mocks when building images, since they're not
even in the final build products and it is a waste of compute. Having it
in here causes spurious errors since we run `go generate` with a
throwaway go.mod. This is to improve Docker caching.

Closes #970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timraymond timraymond

Labels
area/infra Test, Release, or CI Infrastructure priority/0 P0 type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove mockgen from go generate step microsoft/retina
2 participants
@timraymond @anubhabMajumdar