Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retina capture list requires name to be passed #890

Open
tamilmani1989 opened this issue Oct 24, 2024 · 2 comments
Open

Retina capture list requires name to be passed #890

tamilmani1989 opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels

Comments

@tamilmani1989
Copy link
Contributor

Describe the bug
retina capture list requires name otherwise it throws error required flag(s) "name" not set

To Reproduce
Download latest retina from github(0.0.16).. Run kubectl retina capture list

Expected behavior
kubectl retina capture list

The above command expected to show all capture created in default namespace.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

  • OS: [e.g. AzureLinux]
  • Kubernetes Version: [e.g. 1.22]
  • Host: [e.g. AKS, KIND, self-host, etc]
  • Retina Version: 0.0.16

Additional context
Add any other context about the problem here.

@k-nzw
Copy link

k-nzw commented Oct 25, 2024

I think this behavior has been introduced by PR #275 unintentionally.
Making the name flag global in the capture command requires name to be passed even in the capture list command.

@kamilprz
Copy link
Contributor

I believe this should be fixed in the next release. I removed the requirement for the name flag to be required here

When building the CLI from source on my machine, I can run kubectl retina capture list without passing any flags.
Image

From my understanding, the way to install the CLI is through Krew, which uses the a krew-index based on the latest release of Retina. The PRs I made where after the 0.0.16 release, so are not included there, but should be in 0.0.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants