Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit support for multiline messages in problem matchers #62

Open
tido64 opened this issue Apr 9, 2020 · 1 comment
Open

Revisit support for multiline messages in problem matchers #62

tido64 opened this issue Apr 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tido64
Copy link
Member

tido64 commented Apr 9, 2020

Due to a limitation in the format of problem matchers, it's currently not possible to extract multiline messages. For input such as:

TestTestApp#test_resources_pod_returns_spec_path [test/test_test_app.rb:31]:
Expected: ".."
  Actual: "."

"Expected: …" and "Actual: …" are two separate errors with this matcher. We are currently not able to match output such as:

TestTestApp#test_resources_pod_writes_podspec [test/test_test_app.rb:50]:
--- expected
+++ actual
@@ -1 +1 @@
-["dist/assetd", "dist/main.jsbundle"]
+["dist/assets", "dist/main.jsbundle"]

This issue has been reported in actions/toolkit#193 and actions/toolkit#319.

Originally posted by @tido64 in #61

@tido64 tido64 added the enhancement New feature or request label Apr 9, 2020
@ssbarnea

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants