Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchlib] IRFFT implementation is not correct #1271

Open
justinchuby opened this issue Feb 7, 2024 · 4 comments · May be fixed by #1844
Open

[torchlib] IRFFT implementation is not correct #1271

justinchuby opened this issue Feb 7, 2024 · 4 comments · May be fixed by #1844
Assignees
@fatcat-z
Labels
bug Something isn't working contribution welcome We welcome code contributions for this topic: torch_lib Related to the torch/aten function lib in development

Comments

@justinchuby
Copy link
Collaborator

justinchuby commented Feb 7, 2024 •
edited
Loading

pytorch/pytorch#119360
@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Feb 7, 2024
@titaiwangms
Copy link
Contributor

fft family issue

https://github.com/pytorch/pytorch/blob/02c24b0b5e3da098ddc34912c009089b6ffc8600/test/onnx/test_fx_op_consistency.py#L430-L477

@justinchuby
Copy link
Collaborator Author

Was fft still failing? Do we know what the failing cases are?

@justinchuby justinchuby added the bug Something isn't working label Feb 8, 2024
@justinchuby justinchuby changed the title [torchlib] IRFFT [torchlib] IRFFT implementation is not correct Feb 8, 2024
@justinchuby justinchuby added the contribution welcome We welcome code contributions for this label Feb 8, 2024
@justinchuby
Copy link
Collaborator Author

cc @fatcat-z

@titaiwangms titaiwangms mentioned this issue Feb 8, 2024
Closed
@fatcat-z
Copy link
Contributor

The root cause it that last_dim_size was not handled correctly, working on it.

Affected issues:

pytorch/pytorch#113444

@justinchuby justinchuby linked a pull request Sep 3, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatcat-z fatcat-z

Labels
bug Something isn't working contribution welcome We welcome code contributions for this topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[torchlib] Fix _fft_c2r justinchuby/onnxscript
3 participants
@justinchuby @titaiwangms @fatcat-z