Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch api] Update external tensor handling for large attributes #1835

Open
justinchuby opened this issue Aug 29, 2024 · 0 comments
Open

[torch api] Update external tensor handling for large attributes #1835

justinchuby opened this issue Aug 29, 2024 · 0 comments

Comments

@justinchuby
Copy link
Collaborator

          I am fine with adjusting the implementation later on, as long as we are fine with the API here. I think we may be better off making all tensors (initializers and node-attributes) of size above a cutoff limit external, leaving the rest internal. But I am fine if the cutoff limit is hard-coded in this logic for now ... only if we want to expose this to users, does it get a bit more complicated.

Originally posted by @gramalingam in #1832 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant