Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Values that are initialized but not graph inputs do not have their ValueInfo preserved #1501

Open
justinchuby opened this issue May 6, 2024 · 2 comments · May be fixed by #1552
Open
Labels
bug Something isn't working contribution welcome We welcome code contributions for this topic: IR Intermediate representation
Milestone

Comments

@justinchuby
Copy link
Collaborator

Currently the values in the graph that are not inputs and do not have producing nodes are not registered with the graph. Their value info is not preserved at serialization. We need a way to easily access them and be able to serialize them.

@justinchuby justinchuby added bug Something isn't working contribution welcome We welcome code contributions for this topic: IR Intermediate representation labels May 6, 2024
@justinchuby justinchuby mentioned this issue May 6, 2024
67 tasks
@gramalingam
Copy link
Collaborator

Just to clarify, I guess these are initializers (that are not inputs). I realize the title says this, but I wasn't looking at that first!

How do users create them? (In previous frameworks/approaches, typically we used to create "Constant()" op nodes, depending on subsequent processing, if desired, to convert them into initializers.)

@justinchuby
Copy link
Collaborator Author

Just to clarify, I guess these are initializers (that are not inputs). I realize the title says this, but I wasn't looking at that first!

Thanks for clarifying - the title was referring to "initialized objects", but yes they are typically initializers.

How do users create them? (In previous frameworks/approaches, typically we used to create "Constant()" op nodes, depending on subsequent processing, if desired, to convert them into initializers.)

These values are simply ir.Value as inputs to nodes. When deserializing they are created on the fly, but they are not referenced by the graph, and the serializers only create ValueInfo for node outputs and not inputs.

I think we can simply create ValueInfo for all initializers. I will double check if we are doing this already.

@justinchuby justinchuby added this to the 0.1 milestone May 9, 2024
@justinchuby justinchuby linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribution welcome We welcome code contributions for this topic: IR Intermediate representation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants