Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] deviceHandle() interface is counter-intuitive #289

Open
chhwang opened this issue Apr 17, 2024 · 0 comments
Open

[Feature] deviceHandle() interface is counter-intuitive #289

chhwang opened this issue Apr 17, 2024 · 0 comments

Comments

@chhwang
Copy link
Contributor

chhwang commented Apr 17, 2024

Host2DeviceSemaphore::deviceHandle() and SmDevice2DeviceSemaphore::deviceHandle() interfaces look like for retrieving properties of the class object, suggesting usage such as:

SmDevice2DeviceSemaphore sem(communicator, connection);
auto handle = sem.deviceHandle();

But this a case of illegal usage as we need to call communicator.setup() in between the object construction and the call to deviceHandle() method. We may need to either call the setup() internally or make the internal sendMemoryOnSetup() and recvMemoryOnSetup() calls to be more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant