Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Spinner Migration Doc does not include guidance for migrating spinners that have aria-labels and aria-lives from v8 to v9 #33835

Open
3 of 5 tasks
snisonoffMS opened this issue Feb 12, 2025 · 2 comments

Comments

@snisonoffMS
Copy link

Area

React Components (https://react.fluentui.dev)

What kind of documentation issue are you reporting?

  • Reporting a typo
  • Reporting a documentation bug
  • Documentation improvement
  • Documentation feedback

Is there a specific documentation page you are reporting?

https://react.fluentui.dev/?path=/docs/concepts-migration-from-v8-components-spinner-migration--docs

Description

The v9 Spinner does not have an aria-label nor aria-live for the spinner and does not have any suggestions for consumers using the v8 with these props on how to migrate, thus the doc is incomplete.

Validations

  • Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.
@CampbellOwen
Copy link
Contributor

@snisonoffMS Is there an issue with aria-label not being applied to the v9 Spinner?

I tried it in a stackblitz and it appears to work correctly: https://stackblitz.com/edit/epecwzke?file=src%2Fexample.tsx

@snisonoffMS
Copy link
Author

@CampbellOwen You seem to be confusing this issue with #33841 - feel free to close that one because I talked to Sarah about it and it turned out my expected behavior was wrong.

This bug is for the Migration Docs, the fact that the docs imply that the aria-label is gone, when it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants