Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitButton – Target Size (Minimum) (AA) #33650

Closed
Tracked by #32383
gouttierre opened this issue Jan 14, 2025 · 3 comments
Closed
Tracked by #32383

SplitButton – Target Size (Minimum) (AA) #33650

gouttierre opened this issue Jan 14, 2025 · 3 comments

Comments

@gouttierre
Copy link
Contributor

gouttierre commented Jan 14, 2025

Problem

  • Both the medium and small variants fail for the menu button in the horizontal axis. The medium variant fails by only 1px, which should be easy to fix. The small variant fails by 9px.

Current State

  • small: 15x24 ❌
  • med: 23x32 ❌
  • lg: 31x40 ✅ (but should be 32x40)

Components / Button / SplitButton - Docs ⋅ Storybook


Change Needed

  • small: 24x24
  • med: 24x32
  • lg: 32x40

Refer to this Figma UI Kits

@ValentinaKozlova
Copy link
Contributor

Hi @gouttierre,
This bug has been already fixed (small and medium sizes): #32309
Small:
Image

Medium:
Image

@toshie-rashtavie
Copy link

Hi all :) +1 to Valentyna's comment, yep these have been fixed! The 31px is because we'd need to add equal padding on both sides so we can't get the 32px width. I think it's good to have it at 31px!

@ValentinaKozlova
Copy link
Contributor

Closing this issue, as no changes needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants