Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some search parameters support not indicated in CapabilityStatement #4672

Open
tswelsh opened this issue Oct 11, 2024 · 2 comments
Open

Some search parameters support not indicated in CapabilityStatement #4672

tswelsh opened this issue Oct 11, 2024 · 2 comments
Labels
Bug Bug bug bug. Up for grabs The issue require minimal context and is well-suited for new contributors. VSTS-Backlog On VSTS Backlog

Comments

@tswelsh
Copy link

tswelsh commented Oct 11, 2024

Describe the bug
A consumer of our FHIR server refuses to use the _summary search result parameter, as they (reasonably) determine whether they can use it based on its presence in the server's CapabilityStatement. The only items in CapabilityStatement.rest.searchParam are _type and _count (this is on release 4.0.198):

[
    {
        "name": "_type",
        "definition": "http://hl7.org/fhir/SearchParameter/type",
        "type": "token"
    },
    {
        "name": "_count",
        "type": "number"
    }
]

The server does accept a _summary=count and returns a Bundle in the expected form, e.g.

{
    "resourceType": "Bundle",
    "id": "1328b006-3cc2-4935-a832-a6034c8d3806",
    "type": "searchset",
    "total": 121
}

So it seems reasonable that this should be reflected in the CapabilityStatement, probably along with all other supported parameters. See e.g. the lists of Common search parameters and Search result parameters.

FHIR Version?
Stu3

Data provider?
SQL Server

To Reproduce
Steps to reproduce the behavior:

  1. Query the server's capability statement at the /metadata endpoint.

Expected behavior
All supported search/search result parameters will be returned in the CapabilityStatement.

Actual behavior
Not all supported search parameters were returned; in particular _summary is missing.

@tswelsh tswelsh added the Bug Bug bug bug. label Oct 11, 2024
@tswelsh
Copy link
Author

tswelsh commented Oct 11, 2024

The global search parameters appear to be added at https://github.com/microsoft/fhir-server/blob/main/src/Microsoft.Health.Fhir.Core/Features/Conformance/CapabilityStatementBuilder.cs#L172 - explicitly just the 2 parameters mentioned above.

@EXPEkesheth
Copy link
Collaborator

EXPEkesheth commented Oct 14, 2024

Thanks for reporting the issue and we will take a look. AB130950

@EXPEkesheth EXPEkesheth added VSTS-Backlog On VSTS Backlog Up for grabs The issue require minimal context and is well-suited for new contributors. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Up for grabs The issue require minimal context and is well-suited for new contributors. VSTS-Backlog On VSTS Backlog
Projects
None yet
Development

No branches or pull requests

2 participants