Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include doesn't check type of search parameter #2003

Closed
Ivanidzo4ka opened this issue Jun 3, 2021 · 4 comments
Closed

Include doesn't check type of search parameter #2003

Ivanidzo4ka opened this issue Jun 3, 2021 · 4 comments
Labels
Bug Bug bug bug. Review Tag for PM/Dev Review Up for grabs The issue require minimal context and is well-suited for new contributors. VSTS-Backlog On VSTS Backlog
Milestone

Comments

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Jun 3, 2021

Describe the bug
Expression parser doesn't check what search parameter is used for include, which leads to 500.

FHIR Version?
Stu3/R4/R5

Data provider?
CosmosDB/SQL Server

To Reproduce
Steps to reproduce the behavior:

  1. Search Patient?_include=Patient:family
  2. Search Patient?_revinclude=Coverage:identifier

Expected behavior
Either operation bad request or operation outcome which indicate what such include is not supported.

Actual behavior

System.ArgumentNullException: Value can not be null. (Parameter 'resourceId')
   at EnsureThat.Enforcers.AnyArg.IsNotNull[T](T value, String paramName, OptsFn optsFn)
   at EnsureThat.Enforcers.StringArg.IsNotNullOrWhiteSpace(String value, String paramName, OptsFn optsFn)
   at Microsoft.Health.Fhir.CosmosDb.Features.Storage.ResourceTypeAndId..ctor(String resourceTypeName, String resourceId) in D:\src\fhir-server\src\Microsoft.Health.Fhir.CosmosDb\Features\Storage\ResourceTypeAndId.cs:line 21

AB#102855

@Ivanidzo4ka Ivanidzo4ka added the Bug Bug bug bug. label Jun 3, 2021
@CaitlinV39
Copy link
Contributor

CaitlinV39 commented Jun 4, 2021

AB#82654

@CaitlinV39 CaitlinV39 added the VSTS-Backlog On VSTS Backlog label Jun 4, 2021
@CaitlinV39 CaitlinV39 added this to the backlog milestone Sep 16, 2021
@brendankowitz brendankowitz added the Up for grabs The issue require minimal context and is well-suited for new contributors. label Jun 14, 2022
@EXPEkesheth
Copy link
Collaborator

Thanks for reporting the issue. Bug mentioned is addressed with PR #3228

@EXPEkesheth
Copy link
Collaborator

Reopening the issue , as the change was reverted.

@v-shnarang v-shnarang added the Review Tag for PM/Dev Review label Oct 4, 2024
@v-shnarang
Copy link

v-shnarang commented Oct 4, 2024

@EXPEkesheth: This issue should be close as we are not able to reproduce it and also getting the expected output

@microsoft microsoft deleted a comment from v-kulkarnipa Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Review Tag for PM/Dev Review Up for grabs The issue require minimal context and is well-suited for new contributors. VSTS-Backlog On VSTS Backlog
Projects
None yet
Development

No branches or pull requests

5 participants