You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Versions
What package version of the SDK are you using. main
What nodejs version are you using 18
What browser version are you using
Unrelated
What os are you using
Windows
Describe the bug
Some tests are not conclusive because some of their expectations are not running. After fixing them, some issues are discovered with the library. Tests that are failing and some investigations:
Streaming Extensions NamedPipe Library Tests > NamedPipe Transport Tests > throws when reading from a dead socket
This is an issue on production code.
Reading from a dead socket will never resolve/reject.
The only way to reject reading is: read from a live socket, close/error out the socket
Without connecting the named pipe, the send() call will never resolve
The test code should connect to the server and respond, then the send() call will resolve and completing the scenario
Streaming Extensions NamedPipe Library Tests > NamedPipe Server Tests > sends without throwing
This is an issue on test code.
Without connecting the named pipe, the send() call will never resolve
The test code should connect to the client and respond, then the send() call will resolve and completing the scenario
To Reproduce
Currently, those offending tests are disabled by it.skip().
Steps to reproduce the behavior:
Modify offending tests by changing it from it.skip() to it()
Run npm test under /libraries/botframework-streaming
Expected behavior
All tests should pass.
Screenshots
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
compulim
added
bug
Indicates an unexpected problem or an unintended behavior.
needs-triage
The issue has just been created and it has not been reviewed by the team.
labels
Apr 24, 2023
Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Versions
What package version of the SDK are you using.
main
What nodejs version are you using
18
What browser version are you using
Unrelated
What os are you using
Windows
Describe the bug
Some tests are not conclusive because some of their expectations are not running. After fixing them, some issues are discovered with the library. Tests that are failing and some investigations:
send()
call will never resolvesend()
call will resolve and completing the scenariosend()
call will never resolvesend()
call will resolve and completing the scenarioTo Reproduce
Steps to reproduce the behavior:
it.skip()
toit()
npm test
under/libraries/botframework-streaming
Expected behavior
All tests should pass.
Screenshots
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: