Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Not Using SalesLine.GetSalesHeader() in UpdateEntryDescriptionFromSalesLine #2318

Open
1 task
Pieterheinevdm opened this issue Nov 5, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@Pieterheinevdm
Copy link
Contributor

Pieterheinevdm commented Nov 5, 2024

Describe the issue

procedure UpdateEntryDescriptionFromSalesLine in codeunit 815 "Sales Post Invoice" is not using SalesLine.GetSalesHeader() to retreive the salesheader.

procedure UpdateEntryDescriptionFromPurchaseLine in codeunit 816 "Purch. Post Invoice" is not using PurchaseLine.GetPurchHeader() to retreive the purchaseheader.

Expected behavior

old:
SalesSetup.Get();
SalesHeader.get(SalesLine."Document Type", SalesLine."Document No.");
new:
SalesSetup.GetRecordOnce();
SalesHeader := SalesLine.GetSalesHeader();

old:
PurchSetup.Get();
PurchaseHeader.get(PurchaseLine."Document Type", PurchaseLine."Document No.");
new:
PurchSetup.GetRecordOnce();
PurchaseHeader := PurchaseLine.GetPurchHeader();

Steps to reproduce

post a sales and purchase document

Additional context

No response

I will provide a fix for a bug

  • I will provide a fix for a bug
@Pieterheinevdm Pieterheinevdm added the Bug Something isn't working label Nov 5, 2024
@Pieterheinevdm Pieterheinevdm changed the title [Bug]: [Bug]: Using SalesLine.GetSalesHeader() in UpdateEntryDescriptionFromSalesLine Nov 5, 2024
@Pieterheinevdm Pieterheinevdm changed the title [Bug]: Using SalesLine.GetSalesHeader() in UpdateEntryDescriptionFromSalesLine [Bug]: Not Using SalesLine.GetSalesHeader() in UpdateEntryDescriptionFromSalesLine Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant