Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: UpgradeTag does not have a procedure for database upgrade tags #1978

Open
1 task done
TKapitan opened this issue Sep 10, 2024 · 2 comments · May be fixed by #2061
Open
1 task done

[Bug]: UpgradeTag does not have a procedure for database upgrade tags #1978

TKapitan opened this issue Sep 10, 2024 · 2 comments · May be fixed by #2061
Labels
Approved The issue is approved Bug Something isn't working Integration GitHub request for Integration area

Comments

@TKapitan
Copy link
Contributor

Describe the issue

Codeunit 9999 "Upgrade Tag" does not have all procedures for database upgrade tags.the

Expected behavior

While we have

  • UpgradeTag.SetDatabaseUpgradeTag(TagName)

We don't have a corresponding procedure for HasDatabaseUpgradeTag. For this, developers must use HasUpgradeTag(TagName, '') to manually specify a blank company name.

While this is not challenging, it's hard to explain to new developers why we have a special Setter (as the SetUpgradeTag(TagName, '') would also work) but not for Getter.

Steps to reproduce

Additional context

No response

I will provide a fix for a bug

  • I will provide a fix for a bug
@TKapitan TKapitan added the Bug Something isn't working label Sep 10, 2024
@pri-kise
Copy link
Contributor

I recently stumbled over the same issue and this should really be improved.

@JesperSchulz
Copy link
Contributor

Agree. Approved.

@JesperSchulz JesperSchulz added Approved The issue is approved Integration GitHub request for Integration area labels Sep 16, 2024
@TKapitan TKapitan linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Approved The issue is approved Bug Something isn't working Integration GitHub request for Integration area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1978 HasDatabaseUpgradeTag TKapitan/BCApps
3 participants
@JesperSchulz @TKapitan @pri-kise