#1978 HasDatabaseUpgradeTag #2061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AL: System Application
From Fork
NKarolak
suggested changes
Sep 20, 2024
src/System Application/App/Upgrade Tags/src/UpgradeTag.Codeunit.al
Outdated
Show resolved
Hide resolved
Co-authored-by: Natalie Karolak, MVP <[email protected]>
JesperSchulz
approved these changes
Sep 24, 2024
nikolakukrika
approved these changes
Sep 24, 2024
| /// </summary> | ||
| /// <param name="Tag">Tag code to check</param> | ||
| /// <returns>True if the Tag with the given code exists.</returns> | ||
| procedure HasDatabaseUpgradeTag(Tag: Code[250]): Boolean |
There was a problem hiding this comment.
So the idea was to use SetUpgradeTag and HasUpgradeTag only, the code will find out from the context if the tag is per database or per company. Approving since we already have the SetDatabaseUpgradeTag, which is wrongly named IMO. It should be PerDatabaseUpgradeTag
| @@ -43,6 +43,16 @@ codeunit 9999 "Upgrade Tag" | |||
| exit(UpgradeTagImpl.HasUpgradeTag(Tag, TagCompanyName)); | |||
| end; | |||
|
|
|||
| /// <summary> | |||
| /// Verifies if the database upgrade tag exists. | |||
| /// <summary> | ||
| /// Verifies if the database upgrade tag exists. | ||
| /// </summary> | ||
| /// <param name="Tag">Tag code to check</param> |
There was a problem hiding this comment.
Could you add a comment that the developer can use HasUpgradeTag if it is called from the upgrade context? If it is called from upgrade context e.g. OnUpgradePerDatabase we will automatically use perdatabase check and similar for percompany?
Nothing wrong with using this one directly but it could be confusing if someone is reading the existing code.
StefanSosic
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds HasDatabaseUpgradeTag() procedure to make the setters and getters the same.
Work Item(s)
Fixes #1978
Fixes AB#550241