-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move InvokeGenerator to a centralized function of Meshkit #543
Move InvokeGenerator to a centralized function of Meshkit #543
Conversation
Signed-off-by: dusdjhyeon <[email protected]>
Signed-off-by: dusdjhyeon <[email protected]>
Signed-off-by: dusdjhyeon <[email protected]>
Mesehryctl needs update as well, right? Can you please update it too and attach that PR with this. |
Signed-off-by: dusdjhyeon <[email protected]>
@Jougan-0 @dusdjhyeon Is there any change in logic? |
Nope it was just basic migration. |
@dusdjhyeon Did you run this locally? I mean do you have google sheets configured? |
I copied meshery Google sheets in my google account and invited my gcp api email and used it. |
Was everything working fine and models were generated? |
|
Reviewed on Meshery PR to remove logrus please do so and let's get this merged. |
👍 |
Signed-off-by: dusdjhyeon <[email protected]>
Signed-off-by: Dahyeon Kang <[email protected]>
Signed-off-by: dusdjhyeon <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Description
This PR fixes #541
Notes for Reviewers
Signed commits