Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn #1664

Open
flevi29 opened this issue May 29, 2024 · 2 comments
Open

Update yarn #1664

flevi29 opened this issue May 29, 2024 · 2 comments
Labels
maintenance Issue about maintenance (CI, tests, refacto...)

Comments

@flevi29
Copy link
Collaborator

flevi29 commented May 29, 2024

Currently this repository is using yarn classic.

One day, perhaps not too long from now, it will be deprecated for good, it says on the install page.

image

There are benefits to upgrading.

However the new version is to be managed through corepack.
In my opinion the best way forward is to change actions/setup-node@v4 so that it no longer installs yarn globally, but rather enables corepack. #1664 (comment)

Important

This will (theoretically, but I am 99% sure) not impact the rest of the JS repositories, as enabling corepack means that as soon as yarn or pnpm is entered into the command line, corepack installs it (if it isn't already installed), and then executes it. (I'm not sure why, but by default it installs Yarn classic, so it's fine)

Read more about upgrading to the latest Yarn:
https://yarnpkg.com/getting-started/install

Migration should be very simple:
https://yarnpkg.com/migration/guide#migration-steps

@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label May 29, 2024
@flevi29
Copy link
Collaborator Author

flevi29 commented May 30, 2024

Okay, I had some misconceptions. I thought actions/setup-node was a Meilisearch custom script, but it's entirely out of your hands. The approach will be a little different it seems.

actions/setup-node#480
actions/setup-node#482
actions/setup-node#651

It seems like they're not entirely into Corepack, because it's experimental, meanwhile Yarn wants you to use Corepack, so I'm not sure what's going on here. Seems like no one can agree on anything, classic JavaScript community.

@flevi29
Copy link
Collaborator Author

flevi29 commented Oct 10, 2024

Waiting on actions/setup-node#901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

No branches or pull requests

1 participant