Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Add interactive example for web API(Streams API)? #2306

Open
zizifn opened this issue Oct 10, 2022 · 2 comments
Open

[Question] Add interactive example for web API(Streams API)? #2306

zizifn opened this issue Oct 10, 2022 · 2 comments
Labels
idle Issues and pull requests with no activity for three months.

Comments

@zizifn
Copy link

zizifn commented Oct 10, 2022

I want to add an interactive example for https://developer.mozilla.org/en-US/docs/Web/API/Streams_API.

I noticed there is a type: webapi-tabbed , but this is not in the CONTRIBUTING doc, I tested this in my local, this type is working fine.
And the only example inside folder live-examples/webapi-examples is also working fine in PROD env https://interactive-examples.mdn.mozilla.net/pages/webapi-tabbed/document-queryselector.html

So is ok for me to add Streams_API interactive example inside folder live-examples/webapi-examples?

@welcome
Copy link

welcome bot commented Oct 10, 2022

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.

@zizifn zizifn changed the title [Question] Add interactive example for web API? [Question] Add interactive example for web API(Streams API.)? Oct 10, 2022
@zizifn zizifn changed the title [Question] Add interactive example for web API(Streams API.)? [Question] Add interactive example for web API(Streams API)? Oct 10, 2022
@NiedziolkaMichal
Copy link
Member

Lately application used for displaying interactive examples is undergoing some changes. Current version displays output in Shadow DOM, because of which simple DOM queries like document.getElementById doesn't work and code needs to refer to Shadow Root instead:

    let documentRoot = getShadowRoot();
    return documentRoot.querySelector('header');

This is going to change in new version of BOB and linked example will need to be rewritten. Most likely new version will be released when all issues from #881 are resolved. After that, we will be able to publish Web API examples. I can leave this issue open and ping you when that happens.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

No branches or pull requests

2 participants