Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on navigation with open popup #835

Open
chris-mrl opened this issue Jan 22, 2025 · 1 comment · Fixed by #845 · May be fixed by #848
Open

Crash on navigation with open popup #835

chris-mrl opened this issue Jan 22, 2025 · 1 comment · Fixed by #845 · May be fixed by #848

Comments

@chris-mrl
Copy link

Describe the bug
When navigating away from a dockview instance that has an open popup window, the page crashes with a variant (due to minimisation) of the following error:

Cannot destructure property 'value' of 't' as it is undefined.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'dockview demo'
  2. Popout any group to a new window
  3. Leaving the popout open, go back to the tab/window with the demo page open
  4. Navigate away from the page using any of the links in the title bar (Docs, API, Blog)

Expected behavior
Browser should navigate away without crashing

Screenshots
If applicable, add screenshots to help explain your problem.

Image

Desktop (please complete the following information):

  • Browser: Chrome
  • Version: 131.0.6778.265
@chris-mrl
Copy link
Author

#845 to resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant