Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size of full page screenshot #250

Open
sagarvijaygupta opened this issue Jul 30, 2018 · 4 comments
Open

Limit size of full page screenshot #250

sagarvijaygupta opened this issue Jul 30, 2018 · 4 comments

Comments

@sagarvijaygupta
Copy link
Collaborator

Some webpages are extremely big. Some like quora or linkedin come with infinite scroll. We should keep a limit on it.

@Shashi456
Copy link
Contributor

Is there a way to detect infinite scroll in a website ?
I think if you keep a limit on the screenshot there may be some sites which are just long pages but don't get the entire image because of the limit.

Another approach could be whitelisting sites ,like having a case that if the website is quora or LinkedIn or Facebook then the limit could kick in.

@sagarvijaygupta
Copy link
Collaborator Author

Infinite website is just a concern. Generally it starts loading when we reach very end (what I have noticed experimentally). So height provided is its initial height. Just wanted to make sure they don't create a problem.

@marco-c
Copy link
Owner

marco-c commented Jul 30, 2018

We can put a sane limit, it's OK if we don't get all possible images for a website.

@sagarvijaygupta
Copy link
Collaborator Author

We actually want it:
This happened now for
Testing https://planet.mozilla.org/ (bug 10256) in firefox
I got more than 4832 images (all white and blank)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants