Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent sizes of screenshots with each other of chrome and firefox #149

Open
sagarvijaygupta opened this issue Mar 18, 2018 · 4 comments
Labels

Comments

@sagarvijaygupta
Copy link
Collaborator

sagarvijaygupta commented Mar 18, 2018

For images which have different sizes:
https://gitlab.com/marco-c/autowebcompat-data/blob/master/1022_firefox.png
https://gitlab.com/marco-c/autowebcompat-data/blob/master/1022_chrome.png

File "label.py", line 50, in get_new_image
img_blended = Image.blend(background, overlay, 0.5)
File "/home/sagar/anaconda3/envs/autowebcompat/lib/python3.6/site-packages/PIL/Image.py", line 2390, in blend
return im1._new(core.blend(im1.im, im2.im, alpha))
ValueError: images do not match

Overlaying produces the above error.

@Shashi456
Copy link
Contributor

@marco-c do you think inconsistent sizes overall are because of how the crawler interacts with the browser?

@marco-c
Copy link
Owner

marco-c commented Mar 18, 2018

I'm not sure what the exact cause is.

@sagarvijaygupta
Copy link
Collaborator Author

sagarvijaygupta commented Mar 19, 2018

There are 143 such types of inconsistencies. Should we just remove them? And put a check in collect.py so that next time no such screenshots are stored until we get the exact reason for this problem. Or just put a check in label.py?

@marco-c
Copy link
Owner

marco-c commented Mar 19, 2018

No, I'd prefer to keep them. Some of them might be valid after cropping (#115).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants