Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: remove unused Option in Select #4383

Open
1 of 8 tasks
brendanfalkowski opened this issue Jan 29, 2025 · 2 comments · May be fixed by #4384
Open
1 of 8 tasks

[bug]: remove unused Option in Select #4383

brendanfalkowski opened this issue Jan 29, 2025 · 2 comments · May be fixed by #4384
Assignees
@brendanfalkowski
Labels
bug Something isn't working

Comments

@brendanfalkowski
Copy link
Contributor

Describe the bug

In Venia UI, the Select component has an Option sub-component that is unused for years.

In 2018/2019 it was imported and used in Select.

But sometime in 2020/2021, the Informed library was version bumped, and Select now gets the "option" component directly from the parent library.

The unused sub-component should be removed.

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@brendanfalkowski brendanfalkowski added the bug Something isn't working label Jan 29, 2025
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jan 29, 2025

Hi @brendanfalkowski. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

@brendanfalkowski
Copy link
Contributor Author

@magento I am working on this

@brendanfalkowski brendanfalkowski linked a pull request Jan 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendanfalkowski brendanfalkowski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PWA-4383: remove unused “Select/option” sub-component in Venia UI brendanfalkowski/pwa-studio
1 participant
@brendanfalkowski