Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL] Place Order resolver error messages are not displayed #39547

Open
1 of 5 tasks
makkoff opened this issue Jan 16, 2025 · 1 comment
Open
1 of 5 tasks

[GraphQL] Place Order resolver error messages are not displayed #39547

makkoff opened this issue Jan 16, 2025 · 1 comment
Labels
Reported on 2.4.7-p1 Indicates original Magento version for the Issue report.

Comments

@makkoff
Copy link

makkoff commented Jan 16, 2025

Preconditions and environment

  • Magento 2.4.7-p1
  • We use Adobe PWA Studio, but I think it's should be reproducible by using GraphQL only

In 2.4.7 Mageno removed the error formatter and started using a constant and now all custom error messages are returned with error code “UNDEFINED".
\Magento\QuoteGraphQl\Model\Resolver\PlaceOrder resolver returns errors as expected by the new logic:

Image
but then the actual response is formatted in \GraphQL\Executor\ReferenceExecutor::collectAndExecuteSubfields, it collects some subfields(??):

Image
and returns it instead of errors…

Image

Steps to reproduce

  1. Add product to cart
  2. Place order, but it should throw any error during the process

Expected result

Order placing is failed, but we are getting correct error message.

Actual result

Image

Image

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 16, 2025

Hi @makkoff. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reported on 2.4.7-p1 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

2 participants