Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commander brackets support in deck editor and new game dialog #13341

Open
4 tasks
JayDi85 opened this issue Feb 12, 2025 · 1 comment
Open
4 tasks

Add commander brackets support in deck editor and new game dialog #13341

JayDi85 opened this issue Feb 12, 2025 · 1 comment

Comments

@JayDi85
Copy link
Member

JayDi85 commented Feb 12, 2025

Some days ago wizards presented commander brackets system (reddit summary) to rank player's decks.

Image

The main idea: analyse decks same way as legality checks does -- so users can see commander brackets level of their deck. If it will works fine then such filter/requirements can be added to game table/tourney dialogs, so users can check/limit opponent's decks without deck discloses (current users can limit decks by edh levels/points but it's a hidden and non-intuitive feature).

Brackets system must be implemented same as edh power levels -- each deck must be analysed to search and calc cards with specific abilities/effects. Old edh implementation uses text search only (see AbstractCommander->getEdhPowerLevel). But new implementation can use abilities search, not text only.

It's not fully automated feature, but can find out 95% of all use cases. Moxfield has useful tools to find out and check cards/decks for specific bracket level: https://moxfield.com/commanderbrackets

Features to implement:

  • code: add deck analyse feature to find commander bracket level;
  • tests: add some example decks from each level to make sure xmage's bracket system can find correct level;
  • gui: add bracket level info in deck editor (as part of legality check - as 5 level buttons, so users can select cards from 4 level as example);
  • gui: add max bracket limit to new table/tourney dialog (can be added to custom options, default is 5);

Image

@Grath
Copy link
Contributor

Grath commented Feb 13, 2025

I would suggest that this should likely replace the Power Level system, especially given the power level's undocumented functionality for banning a color from your table.

The brackets do not seem to be designed with particular algorithmic support in mind - "no intentional early 2-card infinites" for example in Bracket 3 - but https://commanderspellbook.com/ has a database of 39,887 combos and we could see if we can get a listing of 2-card infinite combos from them to ban those from brackets 1 and 2, then there may be some judgment calls necessary on "is this a 2-card infinite that we should ban from bracket 3 because it's Too Easy To Do?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants