possible off by one error

[mus0u]

i believe the age count is off by one day. The year total rolled over the day before my birthday.

[aarohmankad]

I've experienced the same issue. It's still not fixed.

[sylvia43]

Is this still an issue?

[aarohmankad]

yup. Hasn't been patched

[maccman]

Pull requests welcome :)

[mus0u]

If nobody gets to this before I do I will submit a PR when I get a moment.

[aarohmankad]

Where do we think the error is? I think it could be the duration / (milliseconds in a year), most likely suspect because it's a hard coded number.

https://github.com/maccman/motivation/blob/master/app/app.js#L57

[aarohmankad]

I've submitted a pull request with a hackish change (fine tuning the milliseconds). I've only checked by changing the milliseconds and changing the time on my computer. It just ticks over at a little past 12am.

I implore multiple tests are taken before merging.

[aarohmankad]

Feedback would be appreciated.