Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to rename files within the 'Properties' dialog #324

Closed
goetzc opened this issue Mar 7, 2016 · 2 comments
Closed

Allow to rename files within the 'Properties' dialog #324

goetzc opened this issue Mar 7, 2016 · 2 comments

Comments

@goetzc
Copy link
Contributor

goetzc commented Mar 7, 2016

This is like issue #319, but for the file name. There is actually an editable text filed, but upon clicking OK, the file is not renamed. Not sure if the current behavior it is a bug or a feature, hehe.

pcmanfm-qt_file_prop

@palinek
Copy link
Contributor

palinek commented Mar 7, 2016

Duplicate of lxqt/lxqt#773... one should be closed.

@tsujan
Copy link
Member

tsujan commented Mar 7, 2016

I don't want to start a hot discussion about such a small thing here but if this feature is going to be added, it should NOT be by changing the lineedit string and then pressing Enter or OK; a new button will be needed.

If I made that properties dialog, I would use a selectable label instead of the lineedit, regardless of what other DEs do, because the string is info.

tsujan added a commit to lxqt/libfm-qt that referenced this issue Mar 7, 2016
This commit fixes lxqt/pcmanfm-qt#324 by:

(1) Making the name lineedit read-only by default;
(2) Adding a Rename button in front of it; and
(3) Making the name lineedit editable on toggling the Rename button, so that if OK is pressed (and if the new name is different from the old one), the file will be renamed.

I had to change the form layout of generalPage to grid layout but the spacings are the same.

I left the Rename button enabled for root files because the name lineedit was so too but they cannot be renamed by user, of course.

To testers: You should first (re-)compile PCManFM against libfm-qt.so.3.0.0 to test this commit. This has nothing to do with the commit itself.
tsujan added a commit to lxqt/libfm-qt that referenced this issue Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants