Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.8.3 has no cudart file #44

Closed
cyber827 opened this issue Sep 10, 2024 · 2 comments · Fixed by #45 or #46
Closed

v3.8.3 has no cudart file #44

cyber827 opened this issue Sep 10, 2024 · 2 comments · Fixed by #45 or #46
Labels
implementation Unimplemented feature(s)

Comments

@cyber827
Copy link

Trying to update the comfyui ZLUDA fork which uses v3.8-rocm5 to v3.8.3, but neither the ZLUDA-windows-rocm5-amd64.zip or ZLUDA-windows-rocm6-amd64.zip have the cudart.dll file that v3.8-rocm5 has.

Updating the original v3.8 files with the v3.8.3 files from the .zip and keeping the cudart.dll file from the v3.8 results in comfyui creating blurry images. Tried with both HIP SDK 5.7 and HIP SDK 6.1 installed.
@lshqqytiger lshqqytiger mentioned this issue Sep 11, 2024
Merged
@lshqqytiger lshqqytiger linked a pull request Sep 11, 2024 that will close this issue
Bring back the minimal implementations of runtime API. #45
Merged
@lshqqytiger lshqqytiger added the implementation Unimplemented feature(s) label Sep 11, 2024
@lshqqytiger lshqqytiger mentioned this issue Sep 11, 2024
Merged
@lshqqytiger
Copy link
Owner

v3.8.4 was released with cudart.dll.

@cyber827
Copy link
Author

Great work, thank you. Tried both rocm5 and rocm6, both work but unfortunately I'll have to keep using rocm5 for now since rocm6 doubles the time it takes to generate with gfx1031 using comfyui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implementation Unimplemented feature(s)
Projects
None yet
Milestone
No milestone
2 participants
@lshqqytiger @cyber827